Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatability changes for clm bgc #999

Merged
merged 10 commits into from
Aug 14, 2023
Merged

compatability changes for clm bgc #999

merged 10 commits into from
Aug 14, 2023

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Mar 10, 2023

Description:

These changes are necessary to get FATES compatible with the full BGC call sequence in CLM. Since CLM always has the nitrogen cycle active, with limitation applied by withdolding supplementation, FATES must always present an N litter flux. These changes ensure that in all scenarios (c only, and cnp) we allocated and zero-out the N litter arrays. In the C-only version of fates, we will present the zero fluxes, in the cnp version of fates, these will have real, positive, values.

Synchronized (API change) with CTSM PR 1959

Collaborators:

@adrifoster @billsacks @wwieder @glemieux @ckoven @rosiealice

Expectation of Answer Changes:

We do not expect qualitative changes in FATES runs, wiht the exception of soil related variables, such as SOM, fragmented litter and heterotrophic respiration. These are expected to change in fates runs. These changes are likely to not propogate into FATES-side results, but slight deviations may emerge. non-fates simulations, and fates-sp simulations are not expected to change.

Checklist:

  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run (TBD)
  • If answers were expected to change, evaluation was performed and provided (see CTSM PR)

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Fix incorrect diffuse albedo restart variable
@glemieux
Copy link
Contributor

@rgknox and I discussed potentially addressing #697 here as well.

@glemieux glemieux self-requested a review March 27, 2023 18:30
@rgknox rgknox merged commit 4f41112 into NGEET:main Aug 14, 2023
@rgknox rgknox deleted the clm-cbalance branch October 31, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants